Handle si7021 returning negative humidity #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`si7021_env::humidityBasisPoints` is `unsigned int`, but `SI7021::getHumidityBasisPoints` is returning a value ranged from -600 ... 11900 inclusive, where negative values will underflow to 64936 ... 65535. `struct Payload::humidity` is signed integer and we don't want to modify si7021 library, so we just pad the value when doing conversion, where calculation is done in (signed) floating point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
si7021_env::humidityBasisPointsisunsigned int, butSI7021::getHumidityBasisPointsis returning a value ranged from -600 ... 11900 inclusive, where negative values will underflow to 64936 ... 65535.struct Payload::humidityis signed integer and we don't want to modify si7021 library, so we just cast it as signed integer when doing conversion.Here's one of my emonTH presenting this behavior; my location is constantly very humid so I suspect it has been driven into an extreme state. I'm going to play with built-in heater of si7021 to see if I can make it properly report humidity again.